Skip to content

Adding a live skill search filter to the results section#65

Closed
22oo1cso56mansoorkhan-cell wants to merge 6 commits into
komalharshita:mainfrom
22oo1cso56mansoorkhan-cell:search
Closed

Adding a live skill search filter to the results section#65
22oo1cso56mansoorkhan-cell wants to merge 6 commits into
komalharshita:mainfrom
22oo1cso56mansoorkhan-cell:search

Conversation

@22oo1cso56mansoorkhan-cell

@22oo1cso56mansoorkhan-cell 22oo1cso56mansoorkhan-cell commented May 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Summary [required]

with this pr, we are getting a search option which enables us to search the result by typing the title and description on fucus , no delay.

Related Issue [required]

Closes #8

Changes made:

  • Added search input above results grid with proper accessibility (aria-label)
  • Implemented case-insensitive live filtering on title, description, AND skills/tags
  • Search input only appears when results are present
  • Clearing input restores all cards
  • Styled search input to match existing form design

Technical implementation:

  • Plain JavaScript (no libraries)
  • Input event listener for real-time filtering
  • Extended filter logic to search through project-tag elements
  • Added visually-hidden label for screen readers

Type of Change [required]

  • [✅] Bug fix — resolves a broken behaviour
  • [✅ ] Feature — adds new functionality
  • Data — adds new projects to data/projects.json
  • Documentation — updates docs, README, or code comments only
  • [ ✅] Style — CSS or visual changes only, no logic change
  • Refactor — restructures code without changing behaviour
  • Test — adds or updates tests

What Was Changed [required]

File Change made
template/index.html added search bar
static/style.css Changed to add the styling to search bar
static/script.js Changed to add 'setupFilter()', 'showSearchInput()' and modified 'renderResults()'

How to Test This PR [required]

  1. Clone this branch: git checkout your-branch-name
  2. Install dependencies: pip install -r requirements.txt
  3. Run the app: python app.py
  4. Open http://127.0.0.1:5000 and...
  5. Run the tests: python tests/test_basic.py

Expected test output:
'''
27 passed, 0 failed out of 27 tests
'''

Test Results [required]

image

Screenshots (if UI change)

Before After
image image

Self-Review Checklist [required]

  • [✅ ] I have read CONTRIBUTING.md and followed all guidelines
  • [ ✅] My branch name follows the convention: feat/, fix/, docs/, data/, style/, test/
  • [ ✅] I have run python tests/test_basic.py and all 27 tests pass
  • [ ✅] I have run flake8 . locally and there are no errors
  • [ ✅] I have not introduced any print() or console.log() debug statements
  • [✅ ] Every new function I wrote has a docstring
  • [✅ ] I have not modified files outside the scope of the linked issue
  • [✅ ] If I changed the UI, I tested it at 375px (mobile) and 1280px (desktop)
  • [✅ ] If I added a project to the dataset, it has all required JSON fields

Notes for Reviewer

None

@vercel

vercel Bot commented May 15, 2026

Copy link
Copy Markdown

@22oo1cso56mansoorkhan-cell is attempting to deploy a commit to the komalsony234-1530's projects Team on Vercel.

A member of the Team first needs to authorize it.

github-actions[bot]
github-actions Bot reviewed May 15, 2026
View reviewed changes

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for submitting your first pull request to DevPath.

Before review:

  • Complete the PR template fully
  • Ensure all tests pass
  • Link your PR to an issue
  • Keep changes scoped to the issue

A maintainer will review your contribution soon.

komalharshita
komalharshita requested changes May 15, 2026
View reviewed changes

@komalharshita komalharshita left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution — this is a meaningful UX improvement and the live filtering behavior works well overall.

Before this PR can be approved, a few important changes are still needed:

  1. Please resolve the current merge conflicts with the latest main branch.

  2. The PR should properly link the issue using:
    Closes #8
    instead of only mentioning #8.

  3. The search input currently has no accessibility support. Please add either:

  • a proper <label>
    or
  • an aria-label
  1. The issue specifically mentions a skill search filter, but the current implementation only filters by project title and description. Please extend the filtering logic to also search project skills/tags.

Once these changes are addressed, the PR will be much closer to merge-ready.

@22oo1cso56mansoorkhan-cell

22oo1cso56mansoorkhan-cell commented May 15, 2026

Copy link
Copy Markdown
Author

I have done the given required changes @komalharshita you can review now.....

@komalharshita

komalharshita commented May 17, 2026

Copy link
Copy Markdown
Owner

@22oo1cso56mansoorkhan-cell kindly resolve the merge conflicts before merging

@komalharshita komalharshita added the need review Further information is requested label May 17, 2026
@22oo1cso56mansoorkhan-cell

22oo1cso56mansoorkhan-cell commented May 17, 2026

Copy link
Copy Markdown
Author

@komalharshita could U please help me out with that Merging conflicts..I have tried a lot but still Conflicts are there

@komalharshita

komalharshita commented May 18, 2026

Copy link
Copy Markdown
Owner

@22oo1cso56mansoorkhan-cell sync your branch with the main branch

@22oo1cso56mansoorkhan-cell

22oo1cso56mansoorkhan-cell commented May 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@komalharshita I have resolved the merge conflicts ...Thanks for the help👍..You can review now

@komalharshita

komalharshita commented May 19, 2026

Copy link
Copy Markdown
Owner

@22oo1cso56mansoorkhan-cell merge conflicts still exist

@22oo1cso56mansoorkhan-cell

22oo1cso56mansoorkhan-cell commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@komalharshita When I was merging the incoming and current files to overcome conflicts...The default given below skills arent added as u can see in the video

Screen.Recording.2026-05-20.140610.mp4

shall i fix that as well..?? and then proceed..and there are 2 generate buttons
image

@22oo1cso56mansoorkhan-cell

22oo1cso56mansoorkhan-cell commented May 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

@komalharshita I am delighted to tell that i have done the work. where in:

  1. Removed Merge Conflicts
  2. Done the default skills to add in the input bar
  3. Removed the duplicate generate buttons

@22oo1cso56mansoorkhan-cell

22oo1cso56mansoorkhan-cell commented May 23, 2026

Copy link
Copy Markdown
Author

@komalharshita U can review...

@komalharshita

komalharshita commented May 24, 2026

Copy link
Copy Markdown
Owner

@22oo1cso56mansoorkhan-cell resolve the merge conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments
@komalharshita komalharshita Awaiting requested review from komalharshita

Assignees

No one assigned

Labels

gssoc-2026

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a live skill search filter to the results section

2 participants

@22oo1cso56mansoorkhan-cell @komalharshita